Fix UI bind bugs #1233
Merged
Fix UI bind bugs #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user inputs a key that has no mapping in the engine, that key will result in BUTTON_CODE_NONE. Any UI element which the user has not associated with a key will also map to BUTTON_CODE_NONE. Therefore, pressing these kinds of keys (such as multimedia keys like "Volume Up") can incorrectly trigger UI elements that are un-bound, for example the mp3 player UI. This change will early return for any inputs where the key code inputted was interpreted as BUTTON_CODE_NONE.
The Neo UI elements were only bound once, but if for example the MP3 menu didn't have a bind when that bound logic ran, it would never get associated with a key. Instead, refresh the binds every time, so that they're always guaranteed to be up to date, even if the user re-binds the key after it had been bound (or was previously unbound). We still have the problem here that the user can't assign multiple keybinds for the same command, because the latest bind will always take precedence. Possibly(?) related: NeotokyoRebuild#1166
2 tasks
sunzenshen
approved these changes
Jul 27, 2025
Contributor
|
Now that these are refreshed every time, and each of them is used in one place only, shouldn't we instead just remove the ButtonCode_t vars from the Keys struct? |
Collaborator
Author
Probably. But this is really just a hotfix and not a refactor. |
AdamTadeusz
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1235, #1236
We still have the problem #1237 here that the user can't assign multiple keybinds for the same command, because the latest bind will always take precedence. But that's outside the scope of this PR.
Toolchain
Linked Issues