Unbound keys should not activate unbound UI elements

[Rainyan]

Build Info

0658b63

Description

If the user inputs a key that has no mapping in the engine, that key will result in BUTTON_CODE_NONE. Any UI element which the user has not associated with a key will also map to BUTTON_CODE_NONE. Therefore, pressing these kinds of keys (such as virtual multimedia keys like "Volume Up") can incorrectly trigger UI elements that are un-bound, for example the MP3 player UI, to unwantedly pop up.

Here's a player report from Discord with a video that likely is demonstrating this same problem: https://discord.com/channels/1235346473827434517/1235346647618420876/1391482692377513985

To Reproduce

• Have no keybind set for neo_mp3 MP3 player UI element (or unbind them from your autoexec's, etc)
• Launch the game and enter the main menu
• Close the console if it's open
• Use the "Volume Up" media key from a keyboard with such a button
  • If your keyboard has no such button, other similar multimedia keys/virtual keys may also work
  • Or you could emulate this input in software like AutoHotkey

Expected behavior

Pressing the "Volume Up" media key does not display the MP3 menu.

Actual behavior

Pressing the media key does display the MP3 menu.

Operating System

• Windows
• Linux

Version/Distro

11

Machine's CPU

No response

Machine's GPU

No response

GPU's driver

No response

Build's compiler

No response

Additional context and Screenshots

Possibly related:

• https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes
• https://github.com/NeotokyoRebuild/neo/blob/0658b63c194ccb5d923dcc04168faa9879cd1191/src/vgui2/src/vgui_key_translation.h