Fix custom name mismatch at client disconnect #1222
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
In order to fix this, we gotta cache the last known valid player name, because:
neo/src/game/client/clientmode_shared.cpp
Lines 1137 to 1142 in 23343df
And because the
player_disconnectevent originates from the engine library, we gotta manually fix-up the player name after the fact.Toolchain
Linked Issues