MAX_PLAYERS 101 -> 33 #1213
Merged
MAX_PLAYERS 101 -> 33 #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the x64 update 2fdf6fb, the engine's MAX_PLAYERS limit (for x64) has increased from 33 to 101. Update the main menu's server creation panel slider value to use this definition, instead of hardcoding 32 as the upper bound. We're using MAX_PLAYERS-1 because as per https://github.com/NeotokyoRebuild/neo/blob/8f0fee0b0e4760af3851afb856815de9db2a9250/src/game/shared/shareddefs.h#L285-L287 the maximum gamerules allowed players should be <MAX_PLAYERS to make room for the SourceTV/replay bot on the last allocated slot.
Undo maxplayers change from 2fdf6fb While the engine technically supports 100 players now, keep the maxplayers at parity.
DESTROYGIRL
approved these changes
Jul 10, 2025
Rainyan
added
the
Gameplay
Masterkatze
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert
MAX_PLAYERSfrom 101 to 33.Undo maxplayers change from 2fdf6fb.
While the engine technically supports 100 players now, keep the maxplayers at parity.
Also update the main menu server slider to use the
MAX_PLAYERSdefine for the upper bound.Supersedes #1212
Toolchain
Linked Issues