Skip to content

Don't render glow effect twice, move until after HDR pass so glow colours remain consistent #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamTadeusz merged 1 commit into from
Jul 5, 2025
Merged

Don't render glow effect twice, move until after HDR pass so glow colours remain consistent #1202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/game/client/viewrender.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2188,8 +2188,9 @@ void CViewRender::RenderView( const CViewSetup &viewRender, int nClearFlags, int
pRenderContext.SafeRelease();
}
}

#ifndef NEO
GetClientModeNormal()->DoPostScreenSpaceEffects( &viewRender );
#endif // NEO

// Now actually draw the viewmodel
DrawViewModels( viewRender, whatToDraw & RENDERVIEW_DRAWVIEWMODEL );
Expand Down Expand Up @@ -2249,15 +2250,16 @@ void CViewRender::RenderView( const CViewSetup &viewRender, int nClearFlags, int

PerformScreenSpaceEffects( 0, 0, viewRender.width, viewRender.height );

GetClientModeNormal()->DoPostScreenSpaceEffects( &viewRender );

if ( g_pMaterialSystemHardwareConfig->GetHDRType() == HDR_TYPE_INTEGER )
{
pRenderContext.GetFrom( materials );
pRenderContext->SetToneMappingScaleLinear(Vector(1,1,1));
pRenderContext.SafeRelease();
}

#ifdef NEO // Add glow effect after HDR stuff is done, so the colour of the effect doesn't vary
GetClientModeNormal()->DoPostScreenSpaceEffects(&viewRender);
#endif // NEO
CleanupMain3DView( viewRender );

if ( m_rbTakeFreezeFrame[viewRender.m_eStereoEye ] )
Expand Down