Don't render glow effect twice, move until after HDR pass so glow colours remain consistent #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hdr stuff is finished
Contributor
Author
|
I haven't a scooby why we were doing this twice to begin with, I tagged you @nullsystem since you're there in the git blame but that could be from the tf2 sdk port and I'm actually to blame to begin with |
Collaborator
|
Not even too sure what this about, maybe TF2-SDK port. |
nullsystem
approved these changes
Jul 5, 2025
Rainyan
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With HDR enabled, the colour of the glow effect when using xray in spectate changes depending on the exposure of the camera. This PR moves when post screen space effects are done (currently the xray glow is the only thing done in dopostscreenspaceeffects), and removes a duplicate call to DoPostScreenSpaceEffects.