Fix handling of kwargs in @polynomial_ring #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/fix-kwargs-for-varnames-macros
branch
from
97551de
to
85080c9
Compare
|
@lgoettgens suggested how to improve the tests, which I now did |
lgoettgens
reviewed
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1632 +/- ##
=======================================
Coverage 86.94% 86.94%
=======================================
Files 114 114
Lines 29696 29697 +1
=======================================
+ Hits 25819 25820 +1
Misses 3877 3877 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
lgoettgens
approved these changes
Feb 28, 2024
|
CC @mgkurtz (just so that you now I've been messing with your code ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1631 (was easier than I feared :-) )