Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@polynomial_ring support for key-value pairs is broken #1631

Closed
fingolfin opened this issue Feb 28, 2024 · 0 comments · Fixed by #1632
Closed

@polynomial_ring support for key-value pairs is broken #1631

fingolfin opened this issue Feb 28, 2024 · 0 comments · Fixed by #1632

Comments

@fingolfin
Copy link
Member

This works:

julia> polynomial_ring(QQ, ["x", "y"]; internal_ordering=:lex)
(Multivariate polynomial ring in 2 variables over rationals, AbstractAlgebra.Generic.MPoly{Rational{BigInt}}[x, y])

But the macro version does not:

julia> @polynomial_ring(QQ, ["x", "y"]; internal_ordering=:lex)
ERROR: LoadError: MethodError: no method matching popfirst!(::Tuple{Expr, Symbol, Expr})

Closest candidates are:
  popfirst!(::BitVector)
   @ Base bitarray.jl:868
  popfirst!(::BitSet)
   @ Base bitset.jl:276
  popfirst!(::AbstractChannel)
   @ Base channels.jl:11
  ...

Stacktrace:
 [1] var"@polynomial_ring"(__source__::LineNumberNode, __module__::Module, args::Vararg{Any})
   @ AbstractAlgebra ~/Projekte/OSCAR/AbstractAlgebra.jl/src/misc/VarNames.jl:293
in expression starting at REPL[40]:1

So it tries to popfirst! a macro, which of course doesn't work.

mgkurtz added a commit to mgkurtz/AbstractAlgebra.jl that referenced this issue Feb 29, 2024
fingolfin pushed a commit that referenced this issue Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant