Rename one further kernel method #1616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, missed in the sense that the signature is not replaced. I plan to clean up all this dead code in the next weeks and @thofma wanted to remove the "kernel, but over another ring" functions today anyway. |
|
Ah okay. I stumbled over this as |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
- Coverage 86.98% 86.63% -0.36%
==========================================
Files 114 114
Lines 29686 29660 -26
==========================================
- Hits 25823 25696 -127
- Misses 3863 3964 +101 ☔ View full report in Codecov by Sentry. |
|
Obsolete due to #1617 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this was missed in #1601.
cc @joschmitt @thofma