Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change solving interface #1601

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: Change solving interface #1601

merged 1 commit into from
Feb 12, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Feb 12, 2024

  • Use the Solve.* functionality
  • Hide all previous *solve* and *kernel* functions using
    underscores

[breaking]

@thofma thofma marked this pull request as ready for review February 12, 2024 09:35
@thofma thofma force-pushed the th/solvesolve branch 3 times, most recently from 3a78acb to d70b8a1 Compare February 12, 2024 09:50
src/Matrix.jl Outdated Show resolved Hide resolved
src/Solve.jl Outdated Show resolved Hide resolved
@thofma thofma force-pushed the th/solvesolve branch 10 times, most recently from ceedf89 to 6a39bed Compare February 12, 2024 12:12
- Use the `Solve.*` functionality
- Hide all previous `*solve*` and `*kernel*` functions using
  underscores

[breaking]
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (196795d) 87.02% compared to head (7996731) 86.95%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Matrix.jl 89.70% 7 Missing ⚠️
src/Matrix-Strassen.jl 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
- Coverage   87.02%   86.95%   -0.07%     
==========================================
  Files         115      115              
  Lines       29603    29628      +25     
==========================================
+ Hits        25761    25764       +3     
- Misses       3842     3864      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit f8e2306 into master Feb 12, 2024
13 of 30 checks passed
@thofma thofma deleted the th/solvesolve branch February 12, 2024 16:00
ooinaruhugh pushed a commit to ooinaruhugh/AbstractAlgebra.jl that referenced this pull request Feb 15, 2024
- Use the `Solve.*` functionality
- Hide all previous `*solve*` and `*kernel*` functions using
  underscores

[breaking]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants