Skip to content

[canary-publish] Fix create_release-related logic. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

yujeong-jeon
Copy link
Contributor

@yujeong-jeon yujeong-jeon commented May 8, 2025

Issue

Type of Work

  • Bug Fix
  • Feature Addition
  • Code Improvement

Description of Work

  • There is no tag when publish_script is changeset publish --no-git-tag like.
  • Although user don't create git tag when publishing packages, canary action creates a git tag when gh release so that --no-git-tag is still acceptable.
  • But, when getting commit logs based on this tag, an error occured because a tag is not created yet.
  • So, I fixed logic of getting commit logs by getting logs between baseSha and headSha.
  • Due to this modification, if create_release is true, user must set the @action/checkout with fetch-depth: 0 for getting correct release changelogs.

Review Points

Others

…gs to accept baseSha and headSha to get commit logs
@yujeong-jeon yujeong-jeon requested a review from a team as a code owner May 8, 2025 14:19
@yujeong-jeon yujeong-jeon changed the title [canary-publish] Modify create_release description and update createReleaseForTa… [canary-publish] Fix create_release-related logic. May 8, 2025
@yujeong-jeon
Copy link
Contributor Author

I'll self merge for quick confirmation, I'm sorry.

@yujeong-jeon yujeong-jeon merged commit fd267b0 into main May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant