Skip to content

refactor(script): update animations dependency if present in project #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Dec 18, 2017

No description provided.

@ghost ghost assigned vchimev Dec 18, 2017
@ghost ghost added the in progress label Dec 18, 2017
@vchimev vchimev requested a review from sis0k0 December 18, 2017 10:03
Copy link
Contributor

@sis0k0 sis0k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will add nativescript-angular/animations as a dependency to the project if it's not present. The behavior should be:

  • if it's a dependency -> update it
  • if not a dependency -> do nothing

@@ -13,6 +13,13 @@ const isNgDependency = name => name.startsWith("@angular") ||
name === "zone.js" ||
name === "typescript";

const update = (deps, dep) => {
if (deps[dep.dependencyName]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent the script from adding @angular/platform-browser-dynamic to the dependencies object.

@vchimev vchimev closed this Dec 19, 2017
@vchimev vchimev deleted the vchimev-script branch December 19, 2017 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants