-
-
Notifications
You must be signed in to change notification settings - Fork 193
Notification improvements #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi and thanks for the PR. Did you managed to test this on your application? I ask because I don't think the current facade permits the creation of buttons on Notifications. |
Added the missing methods to both the Notification class and the Facade. |
Do you have a screenshot of it working ? Because from the documentation, actions should be converted to NotificationAction object with a type. |
Great! I will take some time tomorrow to test your PR on my computer. Can you PR the docs in the meantime? |
Done deal! |
This is some amazing work. I'll also give this a test tomorrow and report back. Thank you for your contribution! |
Added
Goes hand in hand with NativePHP/electron#168