Skip to content

Expand notification api with reference and more events #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

andreascreten
Copy link
Contributor

@andreascreten andreascreten commented Feb 20, 2025

Changes

  • Added a reference to the notifications so that you can identify which notification was clicked.

Added

  • Implemented more events for notifications: reply, action, and close.

Goes hand in hand with NativePHP/laravel#498

Copy link
Member

@SRWieZ SRWieZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes, and everything is working as expected. I just encountered an error when sending two notifications one after the other, and they had the same reference.

Next time, try to put your changes in another branch so I can edit myself :)

@andreascreten
Copy link
Contributor Author

Next time, try to put your changes in another branch so I can edit myself :)

Noted! I pushed the fix for the reference.

@SRWieZ SRWieZ merged commit d8537f5 into NativePHP:main Feb 21, 2025
11 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants