Rewrite Discord group sync to use v5 Nameless-Link API #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadhgboyle
force-pushed
the
fix/discord-group-sync-batching
branch
2 times, most recently
from
0216558 to
35b7f5f
Compare
tadhgboyle
commented
Jan 27, 2023
tadhgboyle
force-pushed
the
fix/discord-group-sync-batching
branch
from
6f62b8e to
9783c85
Compare
Derkades
previously approved these changes
Jan 28, 2023
There was a problem hiding this comment.
You've requested my review but I don't know enough about NamelessMC to review this code.
I will say I am happy with the current API, from the perspective of Nameless-Plugin and Nameless-Link. And you tested it and it worked, so that's a good sign (although all previous group sync system iterations also appeared to work)
You will need a second approval anyway, after undoing 2.1.0 line :P
supercrafter100
previously approved these changes
Jan 28, 2023
Derkades
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.