Send more consistent data in update-groups payload
#61
Conversation
|
Not sure about this, as far as I can see the API uses underscores for all fields? Only API methods use dashes EDIT: I see, the serverInfo endpoint is the only endpoint that uses dashes! That's probably where you saw it. Maybe we should update the serverInfo endpoint instead? Just make the API send fields with underscores and with dashes for backwards compatibility. |
| @@ -97,11 +97,11 @@ public void sendMinecraftGroups(final int serverId, final Map<UUID, Set<String>> | |||
| groups.forEach((uuid, playerGroups) -> { | |||
| final JsonObject playerGroupsObject = new JsonObject(); | |||
| playerGroupsObject.add("groups", gson.toJsonTree(playerGroups)); | |||
| groupsJson.add(uuid.toString(), playerGroupsObject); | |||
| groupsJson.add(uuid.toString().replace('-', ''), playerGroupsObject); | |||
There was a problem hiding this comment.
There's a special function NamelessAPI.javaUuidToWebsiteUuid(), but I totally forgot about it :P
There was a problem hiding this comment.
This doesn't compile because it uses an empty character literal
There was a problem hiding this comment.
So used to single quotes 😢
Sounds good! |
|
I was going to fix that myself, but now I don't have to, thanks! |
* Rewrite Discord group sync * fix param * Create new endpoint for plugin to use * wip * wip (will work after NamelessMC/Nameless-Java-API#61) * wip * Undo hardcoded version * Style * Style * Style * Fix nickname sync * UNDO UNDO UNDO
No description provided.