-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate create_plugin_registries
#781
Open
evrose54
wants to merge
14
commits into
main
Choose a base branch
from
automate-create-plugin-registries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_plugin' is called
… don't exist or have moved locations
…not exist at runtime
…requested but doesn't exist in the registry
…enotes we should not rebuild the registry and fail quickly.
…stract method with correct call signature
6 tasks
evrose54
added
Dev Update
Minor developmental releases (Ie, X.Y.X.devN)
refactor
Code refactoring updates
labels
Sep 18, 2024
jsolbrig
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a CLI flag added to allow turning on automatic registry creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Checklist
Related Issues
fixes #647
Correlated PR in data_fusion is required to fix a slowdown to data_fusion procflows which was introduced by this PR.
We can close the correlated PR if we decide to keep this PR as-is. A discussion needs to occur about the downstream impacts of defaulting, or not defaulting, to rebuilding the plugin registries on a plugin retrieval failure.
Testing Instructions
Run
./tests/integration_tests/full_test.sh
Summary
The command 'create_plugin_registries' has greatly improved the time it takes to
operate GeoIPS under the hood. This is because all plugins are no longer loaded into
memory, as we can now traverse a plugin registry to load the exact plugins we need
to, when we need them. Unfortuneately, this requires the user to run
'create_plugin_registries' anytime a new plugin has been added to one or more plugin
packages. We've been thinking for a long time of how to automate this process, and
this update does just that.
'create_plugin_registries' can now either be ran manually, or will attempt to be
done automatically by GeoIPS when a plugin is requested. If a user has no registries
in any of their plugin packages, then this is ran the first time get_plugin is
called when certain attributes of the associated interface are being initialized.
If the registries already exist, but a plugin is missing or seemingly out of sync,
then 'create_plugin_registries' will be ran, and get_plugin will be called again. If
the failure persists, then it is likely a problem on the user's end that they need
to fix before running GeoIPS. Now, users no longer have to run
'create_plugin_registries', unless they choose to do so manually.
File Updates:
Output