Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automating create_plugin_registries #647

Open
2 tasks
evrose54 opened this issue Jun 19, 2024 · 0 comments · May be fixed by #781 or NRLMMD-GEOIPS/data_fusion#36
Open
2 tasks

Automating create_plugin_registries #647

evrose54 opened this issue Jun 19, 2024 · 0 comments · May be fixed by #781 or NRLMMD-GEOIPS/data_fusion#36
Labels
enhancement New feature or request

Comments

@evrose54
Copy link
Contributor

Requested Update

Description

After some conversation, we've came up with some ideas on how to automate create_plugin_registries to ensure the plugin registries are in a correct state whenever GeoIPS is ran.

To start, we'll need to attach a pre-build script to plugin_package installation process, that generates a text file (or other suitable file type) which includes the installation time of that certain package. If this installation time is newer than the modification time of any plugin package's registered_plugins.json (assuming one exists), then run / rerun create_plugin_registries to ensure GeoIPS is in a correct / valid state.

I think it'd probably be a good idea to attach this functionality to the top level __init__.py file of all registered GeoIPS plugin packages. It'd be optimal to have this attached to non-registered plugin packages' top level __init__.py files, so maybe it'd be a good idea to discuss whether or not we want to add this to Template Basic Plugin in the future.

Background and Motivation

This issue comes from the last bullet in this issue #541.

Code to demonstrate issue

geoips.create_plugin_regstries and geoips.plugin_registry.

Checklist for Completion

  • Create a pre-build script which generates the installation time file for each plugin package.
  • Use the information in this file to determine whether or not we should run / re-run create_plugin_registries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant