Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small CLI Refactors needed in a future PR #541

Open
3 of 8 tasks
evrose54 opened this issue May 7, 2024 · 1 comment
Open
3 of 8 tasks

Small CLI Refactors needed in a future PR #541

evrose54 opened this issue May 7, 2024 · 1 comment
Assignees
Labels
cli Command line interface tasks refactor Code refactoring updates

Comments

@evrose54
Copy link
Contributor

evrose54 commented May 7, 2024

Requested Update

Description

This issue was created due to lingering comments on the #444 PR. Since that PR is a dependency of other PRs like #465 and #478 , we are going to wait to make those updates and finish them up in a separate PR once those have been merged. Since none of the comments address actual bugs, this is largely just a refactoring change and is good to wait until we merge the aforementioned PRs.

Checklist for Completion

Add to the following list for all comments that still need addressing.

All bullets in the list above that don't have a referenced issue are either described in their entirety above or will most likely not be addressed / relevant in the future. For example, the point talking about geoips test unit-test doesn't have an issue as that functionality will likely be removed.

@evrose54 evrose54 added the refactor Code refactoring updates label May 7, 2024
@evrose54 evrose54 self-assigned this May 7, 2024
@evrose54 evrose54 mentioned this issue May 7, 2024
6 tasks
@evrose54
Copy link
Contributor Author

evrose54 commented May 8, 2024

A larger change (I'll create another issue later) will be implementing logging within the CLI. See Jeremy's comment at https://github.com/NRLMMD-GEOIPS/geoips/pull/444/files#r1592810697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line interface tasks refactor Code refactoring updates
Projects
None yet
Development

No branches or pull requests

3 participants