Conversation
CunliangGeng
requested changes
May 22, 2025
Member
CunliangGeng
left a comment
CunliangGeng
left a comment
There was a problem hiding this comment.
It's really a powerful filter.
Can you make the placeholder filter data... left aligned? same for user's input.
The filter row is not so visible or obvious for a new user, can you make this feature more obvious so that a user won't think it's just an empty row.
|
CunliangGeng
approved these changes
May 22, 2025
gcroci2
added a commit
that referenced
this pull request
May 23, 2025
* update dev notes with branching and releasing sections * change test to dev * set debug false for release * add detail about debug * debug true * remove darkmode components (#58) * feat: add the possibility to change x-axis in the gm table plot (#59) * add class_bgcs key to processed_data * add dropdown option for x-axis * match styles * display none selector when there is not data * make sure that the plot is reset to default x-axis when new file gets uploaded * fix tests * feat: make the cutoff filter for the scoring datatable clearer, and add filtering functionality to all columns (#57) * make cutoff meaning clearer * add filtering to the candidate links table * remove unused confusing Aa box * fix filtering row visualization * add docs for filters in candidate links tables * remove wrong operator * add link to all filtering operators * align placeholder and user input to the left * feat: add load demo data button for the online demo webapp (#60) * add demo data button * add test for load demo data * add docs for online demo * add unique id to loaded demo data * improve sections order * add cleanup flag, defaulted to True * add test for cleanup flag * change default cutoff to 0 * add readme suggestions * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * Update README.md Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * use conda instead of venv * wrap subsections --------- Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl> * fix linter issue * fix mypy issue * add back ignore missing imports --------- Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented table filtering instead of modifying the scoring cutoff functionality. This approach provides more flexibility while keeping the interface intuitive.
Users can now filter any column in the "Candidate Links" tables using standard operations (equals, greater than, contains, etc.). This enables filtering by "Average Score" values without altering the underlying data calculations or requiring more complex UI changes to the scoring blocks.
The Excel export functionality remains unchanged (i.e., all filtered or unfiltered data is included in the downloaded files, ensuring no information is lost regardless of current view settings).