generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub action to run V4 #695
Merged
shorvath-noaa
merged 10 commits into
NOAA-OWP:master
from
shorvath-noaa:update_github_action_LCv4
Nov 15, 2023
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8f56b92
change test to V4 on HYfeatures
shorvath-noaa 3548aad
add more tests
shorvath-noaa 38c0d04
change dx: param to length_m
shorvath-noaa 147fb07
add LowerColorado yaml file with no DA
shorvath-noaa 323bdc7
store rfc crosswalk info in HYFeatures.py so reading csv file is not …
shorvath-noaa fed5b5f
comment out all outputs for LowerColorado test cases
shorvath-noaa dafd616
update check for writing lite_restart in main
shorvath-noaa 8403045
import rfc_gage info from another file
shorvath-noaa 1956044
create separate file for rfc gage info
shorvath-noaa 707a388
remove rfc gage csv files
shorvath-noaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| # $ python3 -m nwm_routing -f -V4 test_AnA_V4_HYFeature.yaml | ||
| #-------------------------------------------------------------------------------- | ||
| log_parameters: | ||
| #---------- | ||
| showtiming: True | ||
| log_level : DEBUG | ||
| #-------------------------------------------------------------------------------- | ||
| network_topology_parameters: | ||
| #---------- | ||
| supernetwork_parameters: | ||
| #---------- | ||
| geo_file_path: domain/LowerColorado_NGENv20.gpkg | ||
| columns: | ||
| key: 'id' | ||
| downstream: 'toid' | ||
| dx : 'length_m' | ||
| n : 'n' | ||
| ncc : 'nCC' | ||
| s0 : 'So' | ||
| bw : 'BtmWdth' | ||
| waterbody : 'rl_NHDWaterbodyComID' | ||
| gages : 'rl_gages' | ||
| tw : 'TopWdth' | ||
| twcc : 'TopWdthCC' | ||
| musk : 'MusK' | ||
| musx : 'MusX' | ||
| cs : 'ChSlp' | ||
| alt: 'alt' | ||
| waterbody_parameters: | ||
| #---------- | ||
| break_network_at_waterbodies: True | ||
| #-------------------------------------------------------------------------------- | ||
| compute_parameters: | ||
| #---------- | ||
| parallel_compute_method: by-subnetwork-jit-clustered # serial | ||
| compute_kernel : V02-structured | ||
| assume_short_ts : True | ||
| subnetwork_target_size : 10000 | ||
| cpu_pool : 36 | ||
| restart_parameters: | ||
| #---------- | ||
| start_datetime : 2023-04-02_00:00 | ||
| lite_channel_restart_file : #restart/RESTART.2020082600_DOMAIN1 | ||
| lite_waterbody_restart_file : #restart/waterbody_restart_202006011200 | ||
| hybrid_parameters: | ||
| run_hybrid_routing: False | ||
| diffusive_domain : #domain/coastal_domain_subset.yaml | ||
| use_natl_xsections: False | ||
| topobathy_domain : #domain/final_diffusive_natural_xs.nc | ||
| run_refactored_network: False | ||
| refactored_domain: #domain/refactored_coastal_domain_subset.yaml | ||
| refactored_topobathy_domain: #domain/refac_final_diffusive_natural_xs.nc | ||
| coastal_boundary_domain: #domain/coastal_boundary_domain.yaml | ||
| forcing_parameters: | ||
| #---------- | ||
| qts_subdivisions : 12 | ||
| dt : 300 # [sec] | ||
| qlat_input_folder : channel_forcing | ||
| qlat_file_pattern_filter : "*.CHRTOUT_DOMAIN1.csv" | ||
| coastal_boundary_input_file : #boundary_forcing | ||
| nts : 288 # 288 for 1day; 2592 for 9 days | ||
| max_loop_size : 24 # [hr] | ||
| data_assimilation_parameters: | ||
| #---------- | ||
| usgs_timeslices_folder : usgs_timeslices/ | ||
| usace_timeslices_folder : usace_timelices/ | ||
| streamflow_da: | ||
| #---------- | ||
| streamflow_nudging : False | ||
| diffusive_streamflow_nudging : False | ||
| lastobs_output_folder : lastobs/ | ||
| reservoir_da: | ||
| #---------- | ||
| reservoir_persistence_da: | ||
| #---------- | ||
| reservoir_persistence_usgs : False | ||
| reservoir_persistence_usace : False | ||
| reservoir_rfc_da: | ||
| #---------- | ||
| reservoir_rfc_forecasts : False | ||
| reservoir_rfc_forecasts_time_series_path: rfc_timeseries/ | ||
| reservoir_rfc_forecasts_lookback_hours : 28 | ||
| reservoir_rfc_forecasts_offset_hours : 28 | ||
| #-------------------------------------------------------------------------------- | ||
| # output_parameters: | ||
| # #---------- | ||
| # test_output : output/lcr_flowveldepth.pkl | ||
| # lite_restart: | ||
| # #---------- | ||
| # lite_restart_output_directory: restart/ | ||
| # lakeout_output: lakeout/ | ||
| # stream_output : | ||
| # stream_output_directory: output/ | ||
| # stream_output_time: 1 #[hr] | ||
| # stream_output_type: '.nc' #please select only between netcdf '.nc' or '.csv' or '.pkl' | ||
| # stream_output_internal_frequency: 60 #[min] it should be order of 5 minutes. For instance if you want to output every hour put 60 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this will eventually be an external resource, could we make the temporary fix also an external file and import(e.g.,
from rfc_lake_gage_crosswalk import rfc_dict), rather than baking the dictionary into this file? It would be easy for this to linger for a while.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes have been made.