Update GitHub action to run V4

[shorvath-noaa]

Updates to github action to perform more test runs. In addition to LowerColorado_TX V3, this will now run V4 on NHD, V4 on HYFeatures, and V4 on HYFeatures with all data assimilation turned off.

Additions

test/LowerColorado_TX_v4/test_AnA_V4_HYFeature_noDA.yaml

• Same as test_AnA_V4_HYFeature.yaml, but with DA turned off

Removals

Changes

.github/workflows/ubuntu-latest.yml

• Run V3 Test
• Run V4 Test on NHD
• Run V4 Test on HYFeature
• Run V4 Test on HYFeature without DA

test/LowerColorado_TX_v4/test_AnA_V4_HYFeature.yaml

• Changed dx: parameter from lengthkm to length_m
• Changed default output file type from .pkl to .nc

Testing

1. These will be triggered on all new pull requests and pushes to master branch

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

Accessibility

• Keyboard friendly
• Screen reader friendly

Other

• Is useable without CSS
• Is useable without JS
• Flexible from small to large screens
• No linting errors or warnings
• JavaScript tests are passing

[shorvath-noaa]

@kumdonoaa @JurgenZach-NOAA @AminTorabi-NOAA this is ready for review. It triggered itself and all tests passed. I made some changes to the test config files for LowerColorado (turned off all output parameters). I also updated how the rfc_lake_gage_crosswalk dataframe is created. The crosswalk is now just stored in HYFeaturesNetwork.py, so t-route no longer needs to read the .csv file. I also updated the check for lite_restart output in main.

[jameshalgren]

If this will eventually be an external resource, could we make the temporary fix also an external file and import(e.g., from rfc_lake_gage_crosswalk import rfc_dict), rather than baking the dictionary into this file? It would be easy for this to linger for a while.

[shorvath-noaa]

These changes have been made.