Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored cfe submodule #664

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Nov 1, 2023

Update the vendored version of the cfe submodule. Several additions and changes are introduced in this update. To the best of my abilities, these additions and changes are listed below.

Note, with this update, extern/cfe/CMakeList.txt is now out of date and will not build all portions of cfe. Before merging this PR, the CMakeList in extern/cfe either needs to be updated or removed. In the mean time, the latest version of cfe can be built (from the root of the ngen repo) using:

cmake -DNGEN=ON -B extern/cfe/cfe/cmake_build -S extern/cfe/cfe 
cmake --build extern/cfe/cfe/cmake_build

Additions

Changes

Todos

  • Update / remove extern/cfe/CMakeList.txt

Notes:

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@aaraney
Copy link
Member Author

aaraney commented Nov 1, 2023

I feel like we should bump the minor version of cfe in CMakeList.txt. Thoughts?

@hellkite500
Copy link
Member

My only concern is making sure we have updated configs for any integration tests, both internal gtests and any workflow test that builds from the submodule.

@PhilMiller
Copy link
Contributor

Could this be rebased and the submodule version in here be updated, so that we also get NOAA-OWP/cfe#101

That would unblock #694

note, with this update, extern/cfe/CMakeList.txt is now out of date and
will not build all portions of cfe.
@hellkite500 hellkite500 merged commit 4949cc1 into NOAA-OWP:master Jan 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants