Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ajk/cfebmi_shared_library #81

Merged
merged 3 commits into from
Apr 12, 2023
Merged

ajk/cfebmi_shared_library #81

merged 3 commits into from
Apr 12, 2023

Conversation

ajkhattak
Copy link
Contributor

Modified CMakeLists.txt in CFE to make BMI shared library file

Additions

  • Added option to CMakeLists.txt to build CFE with shared library (cfebmi) to be used in the nextgen runs

Removals

  • None

Testing

  1. tested update cmakelist.txt on macOS

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Reviewers requested with the Reviewers tool ➡️

mattw-nws
mattw-nws approved these changes Apr 10, 2023
View reviewed changes
Copy link

@mattw-nws mattw-nws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good and tested/works on Hera!

@ajkhattak ajkhattak merged commit da5b5f6 into master Apr 12, 2023
@aaraney aaraney mentioned this pull request Nov 1, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattw-nws mattw-nws mattw-nws approved these changes

@SnowHydrology SnowHydrology Awaiting requested review from SnowHydrology

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajkhattak @mattw-nws