String passing fixes

include/core/HY_Features.hpp

@@ -102,7 +102,7 @@ namespace hy_features {
          * @param id 
          * @return std::shared_ptr<HY_HydroNexus> 
          */
-        std::shared_ptr<HY_HydroNexus> nexus_at(std::string id)
+        std::shared_ptr<HY_HydroNexus> nexus_at(const std::string& id)
         {
           if( _nexuses.find(id) != _nexuses.end() )
             return _nexuses[id];
@@ -131,7 +131,7 @@ namespace hy_features {
          * @param id 
          * @return std::vector<std::shared_ptr<HY_HydroNexus>> 
          */
-        inline std::vector<std::shared_ptr<HY_HydroNexus>> destination_nexuses(std::string  id)
+        inline std::vector<std::shared_ptr<HY_HydroNexus>> destination_nexuses(const std::string&  id)
         {
           std::vector<std::shared_ptr<HY_HydroNexus>> downstream;
           if( _catchments.find(id) != _catchments.end())

include/core/HY_Features_MPI.hpp

@@ -29,11 +29,11 @@ namespace hy_features {
             return network.filter("cat");
         }
 
-        inline bool is_remote_sender_nexus(std::string id) {
+        inline bool is_remote_sender_nexus(const std::string& id) {
             return _nexuses.find(id) != _nexuses.end() && _nexuses[id]->is_remote_sender();
         }
 
-        inline std::vector<std::shared_ptr<HY_HydroNexus>> destination_nexuses(std::string id) {
+        inline std::vector<std::shared_ptr<HY_HydroNexus>> destination_nexuses(const std::string& id) {
             std::vector<std::shared_ptr<HY_HydroNexus>> downstream;
             if (_catchments.find(id) != _catchments.end()) {
                 for(const auto& nex_id : _catchments[id]->get_outflow_nexuses()) {
@@ -43,7 +43,7 @@ namespace hy_features {
             return downstream;
         }
 
-        std::shared_ptr<HY_HydroNexus> nexus_at(std::string id) {
+        std::shared_ptr<HY_HydroNexus> nexus_at(const std::string& id) {
             return (_nexuses.find(id) != _nexuses.end()) ? _nexuses[id] : nullptr;
         }
 

include/core/network.hpp

@@ -228,15 +228,15 @@ namespace network {
          * @param id 
          * @return std::vector<std::string> 
          */
-        std::vector<std::string> get_origination_ids(std::string id);
+        std::vector<std::string> get_origination_ids(const std::string& id);
 
         /**
          * @brief Get the destination (downstream) ids (immediate neighbors) of all vertices with an edge from @p id
          * 
          * @param id 
          * @return std::vector<std::string> 
          */
-        std::vector<std::string> get_destination_ids(std::string id);
+        std::vector<std::string> get_destination_ids(const std::string& id);
 
         /**
          * @brief The number of features in the network (number of vertices)

include/geojson/FeatureCollection.hpp

@@ -152,19 +152,19 @@ namespace geojson {
 
             void visit_features(FeatureVisitor& visitor);
 
-            void set(std::string key, short value);
+            void set(const std::string& key, short value);
 
-            void set(std::string key, int value);
+            void set(const std::string& key, int value);
 
-            void set(std::string key, long value);
+            void set(const std::string& key, long value);
 
-            void set(std::string key, float value);
+            void set(const std::string& key, float value);
 
-            void set(std::string key, double value);
+            void set(const std::string& key, double value);
 
-            void set(std::string key, std::string value);
+            void set(const std::string& key, std::string value);
 
-            void set(std::string key, JSONProperty& property);
+            void set(const std::string& key, JSONProperty& property);
 
             void add_feature(Feature feature, std::string *id = nullptr);
 
@@ -174,13 +174,13 @@ namespace geojson {
              * @param id The id used to reference a feature
              * @param feature A feature that may be referred to by id
              */
-            void add_feature_id(std::string id, Feature feature);
+            void add_feature_id(const std::string& id, Feature feature);
 
-            void set_ids_from_member(std::string member_name = "id");
+            void set_ids_from_member(const std::string& member_name = "id");
 
-            void set_ids_from_property(std::string property_name = "id");
+            void set_ids_from_property(const std::string& property_name = "id");
 
-            void set_ids(std::string id_field_name = "id");
+            void set_ids(const std::string& id_field_name = "id");
 
             void update_ids();
 

include/geojson/features/FeatureBase.hpp

@@ -209,7 +209,7 @@ namespace geojson {
              * @param key The name of the property to get
              * @return The property identified by the key
              */
-            virtual JSONProperty get_property(std::string key) const {
+            virtual JSONProperty get_property(const std::string& key) const {
                 if (properties.find(key) == properties.end()) {
                     std::string error_message = "JSON Property '" + key + "' not found."; 
                     throw std::invalid_argument(error_message);
@@ -223,7 +223,7 @@ namespace geojson {
              * 
              * @param new_id The new identifier for this feature
              */
-            virtual void set_id(std::string new_id) {
+            virtual void set_id(const std::string& new_id) {
                 id = new_id;
             }
 
@@ -233,7 +233,7 @@ namespace geojson {
              * @param key The name of the foreign member whose value to look for
              * @return The member value identified by the key
              */
-            virtual JSONProperty get(std::string key) const {
+            virtual JSONProperty get(const std::string& key) const {
                 return foreign_members.at(key);
             }
 
@@ -243,7 +243,7 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, short value) {
+            virtual void set(const std::string& key, short value) {
                 foreign_members.emplace(key, JSONProperty(key, value));
             }
 
@@ -253,7 +253,7 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, int value) {
+            virtual void set(const std::string& key, int value) {
                 foreign_members.emplace(key, JSONProperty(key, value));
             }
 
@@ -263,7 +263,7 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, long value) {
+            virtual void set(const std::string& key, long value) {
                 foreign_members.emplace(key, JSONProperty(key, value));
             }
 
@@ -273,7 +273,7 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, float value) {
+            virtual void set(const std::string& key, float value) {
                 foreign_members.emplace(key, JSONProperty(key, value));
             }
 
@@ -283,7 +283,7 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, double value) {
+            virtual void set(const std::string& key, double value) {
                 foreign_members.emplace(key, JSONProperty(key, value));
             }
 
@@ -293,7 +293,7 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, std::string value) {
+            virtual void set(const std::string& key, std::string value) {
                 foreign_members.emplace(key, JSONProperty(key, value));
             }
 
@@ -303,11 +303,11 @@ namespace geojson {
              * @param key The name of the value to set
              * @param value The value to set
              */
-            virtual void set(std::string key, JSONProperty property) {
+            virtual void set(const std::string& key, JSONProperty property) {
                 foreign_members.emplace(key, property);
             }
 
-            virtual bool has_key(std::string key) {
+            virtual bool has_key(const std::string& key) {
                 std::vector<std::string> all_keys = this->keys();
 
                 for(auto member_key : all_keys) {

src/core/network.cpp

@@ -154,7 +154,7 @@ std::size_t Network::size(){
   return num_vertices(this->graph);
 }
 
-std::vector<std::string> Network::get_origination_ids(std::string id){
+std::vector<std::string> Network::get_origination_ids(const std::string& id){
   Graph::in_edge_iterator begin, end;
   boost::tie(begin, end) = boost::in_edges (this->descriptor_map[id], this->graph);
   std::vector<std::string> ids;
@@ -165,7 +165,7 @@ std::vector<std::string> Network::get_origination_ids(std::string id){
   return ids;
 }
 
-std::vector<std::string> Network::get_destination_ids(std::string id){
+std::vector<std::string> Network::get_destination_ids(const std::string& id){
   Graph::out_edge_iterator begin, end;
   boost::tie(begin, end) = boost::out_edges (this->descriptor_map[id], this->graph);
   std::vector<std::string> ids;

src/geojson/FeatureCollection.cpp

@@ -100,31 +100,32 @@ void FeatureCollection::visit_features(FeatureVisitor& visitor) {
     }
 }
 
-void FeatureCollection::set(std::string key, short value) {
+void FeatureCollection::set(const std::string& key, short value) {
     foreign_members.emplace(key, JSONProperty(key, value));
 }
 
-void FeatureCollection::set(std::string key, int value) {
+void FeatureCollection::set(const std::string& key, int value) {
     foreign_members.emplace(key, JSONProperty(key, value));
 }
 
-void FeatureCollection::set(std::string key, long value) {
+void FeatureCollection::set(const std::string& key, long value) {
     foreign_members.emplace(key, JSONProperty(key, value));
 }
 
-void FeatureCollection::set(std::string key, float value) {
+void FeatureCollection::set(const std::string& key, float value) {
     foreign_members.emplace(key, JSONProperty(key, value));
 }
 
-void FeatureCollection::set(std::string key, double value) {
+void FeatureCollection::set(const std::string& key, double value) {
     foreign_members.emplace(key, JSONProperty(key, value));
 }
 
-void FeatureCollection::set(std::string key, std::string value) {
+// the 'value' arguement will be copied and then moved so only one copy should occure
+void FeatureCollection::set(const std::string& key, std::string value) {
     foreign_members.emplace(key, JSONProperty(key, value));
 }
 
-void FeatureCollection::set(std::string key, JSONProperty& property) {
+void FeatureCollection::set(const std::string& key, JSONProperty& property) {
     foreign_members.emplace(key, property);
 }
 
@@ -208,7 +209,7 @@ void FeatureCollection::add_feature(Feature feature, std::string *id) {
     }
 }
 
-void FeatureCollection::set_ids_from_member(std::string member_name) {
+void FeatureCollection::set_ids_from_member(const std::string& member_name) {
     for (auto feature : this->features) {
         if(contains(feature->keys(), member_name)) {
             feature->set_id(feature->get(member_name).as_string());
@@ -218,7 +219,7 @@ void FeatureCollection::set_ids_from_member(std::string member_name) {
     this->update_ids();
 }
 
-void FeatureCollection::set_ids_from_property(std::string property_name) {
+void FeatureCollection::set_ids_from_property(const std::string& property_name) {
     for (auto feature : this->features) {
         if (contains(feature->property_keys(), property_name)) {
             feature->set_id(feature->get_property(property_name).as_string());
@@ -228,7 +229,7 @@ void FeatureCollection::set_ids_from_property(std::string property_name) {
     this->update_ids();
 }
 
-void FeatureCollection::set_ids(std::string id_field_name) {
+void FeatureCollection::set_ids(const std::string& id_field_name) {
     for (auto feature : this->features) {
         if(contains(feature->property_keys(), id_field_name)) {
             feature->set_id(feature->get_property(id_field_name).as_string());
@@ -250,7 +251,7 @@ void FeatureCollection::update_ids() {
     }
 }
 
-void FeatureCollection::add_feature_id(std::string id, Feature feature) {
+void FeatureCollection::add_feature_id(const std::string& id, Feature feature) {
     if (id != "") {
         feature_by_id.emplace(id, std::move(feature));
     }