String passing fixes

[donaldwj]

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Change frequently called function to take std::string& instead of std::string to avoid copys

Testing

1. Auto test passed on USC7

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• Linux

[hellkite500]

Other than the unit converter message line, everything else looks like solid string optimizations.

[hellkite500]

need to remove this. If you want to disable unit messages, build with -DUDUNITS_QUIET

[donaldwj]

I think that is a commit that somehow got from one of my profiling branches into my main and has been rebased onto code sense then.

[donaldwj]

Any it is removed

[hellkite500]

Should be good to merge, this one change shouldn't affect the tests

[hellkite500]

I thought there was a larger issue about string handling for performance, but I'm not finding it, but I did want to note the relation to #443 and #444.