Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dmod.core serialization and deserialization types #256

Merged
merged 54 commits into from
Jan 25, 2023
Merged

Refactor dmod.core serialization and deserialization types #256

merged 54 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. fix setup.py confict

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    51b36d5 View commit details
    Browse the repository at this point in the history

  2. add PydanticEnum. validated by enum member name. 

    Subtypes of this enum variant that are embedded in a pydantic model will be:
  - coerced into an enum instance using member name (case insensitive)
  - and expose member names (upper case) in model json schema.
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    282daf9 View commit details
    Browse the repository at this point in the history

  3. add PydanticEnum unittests

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    38de919 View commit details
    Browse the repository at this point in the history

  4. Serializable subclasses pydantic.BaseModel and update docs

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    191ca89 View commit details
    Browse the repository at this point in the history

  5. add deprecated decorator function

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7f081e3 View commit details
    Browse the repository at this point in the history

  6. add unit test to verify deprecated warning is raised by decorator

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7b7b467 View commit details
    Browse the repository at this point in the history

  7. add deprecation warning to parse_simple_serialized

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0945a99 View commit details
    Browse the repository at this point in the history

  8. fix docstring typo

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4687511 View commit details
    Browse the repository at this point in the history

  9. refactor SerializedDict, ResultIndicator, and BasicResultIndicator

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a81a4b5 View commit details
    Browse the repository at this point in the history

  10. refactor AllocationParadigm

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    bed9fef View commit details
    Browse the repository at this point in the history

  11. refactor meta_data enums

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    db06da3 View commit details
    Browse the repository at this point in the history

  12. refactor ContinuousRestriction to use pydantic

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5470ddf View commit details
    Browse the repository at this point in the history

  13. add default implimentation for factory_init_from_deserialized_json

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    48d69f7 View commit details
    Browse the repository at this point in the history

  14. add comment to SerializedDict

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    12512db View commit details
    Browse the repository at this point in the history

  15. refactor BasicResultIndicator

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    25202cf View commit details
    Browse the repository at this point in the history

  16. refactor DiscreteRestriction

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1fb6304 View commit details
    Browse the repository at this point in the history

  17. refactor DataDomain

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d61219a View commit details
    Browse the repository at this point in the history

  18. refactor DataRequirement

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4a1ba96 View commit details
    Browse the repository at this point in the history

  19. remove unnecessary factory_init_from_deserialized_json's

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    47f2b2f View commit details
    Browse the repository at this point in the history

  20. remove unneeded class variables

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d18ed2d View commit details
    Browse the repository at this point in the history

  21. remove ellipse

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    31d0647 View commit details
    Browse the repository at this point in the history

  22. refactor dataset module enums

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a998101 View commit details
    Browse the repository at this point in the history

  23. refactor Dataset

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2abf28f View commit details
    Browse the repository at this point in the history

  24. add bug fix todo's

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e9170ef View commit details
    Browse the repository at this point in the history

  25. fix **kwargs bug

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    db68fab View commit details
    Browse the repository at this point in the history

  26. clean up imports

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5f7bc0f View commit details
    Browse the repository at this point in the history

  27. update unittests. no breaking changes made

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f486264 View commit details
    Browse the repository at this point in the history

  28. serialize UUID using explict cast to str

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    cabf1c1 View commit details
    Browse the repository at this point in the history

  29. update dataset unittest

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9b000c5 View commit details
    Browse the repository at this point in the history

  30. adjust factory init logic in ContinuousRestriction

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f2ca2ec View commit details
    Browse the repository at this point in the history

  31. add meta_data module unit tests

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    be9c8a8 View commit details
    Browse the repository at this point in the history

  32. remove unnecessary return by_alias check. now handled by superclass, … 

    …Serializable.
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    49d1233 View commit details
    Browse the repository at this point in the history

  33. handle coercing bool str repr into python type

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    91f3e86 View commit details
    Browse the repository at this point in the history

  34. add method that encodes python built in types as str (i.e. 'int') and… 

    … all other as 'Any'
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4290455 View commit details
    Browse the repository at this point in the history

  35. correctly deserialize DataDomain's custom_data_fields field

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    18d8496 View commit details
    Browse the repository at this point in the history

  36. ensure restriction fields have empty list by default

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b42a8fe View commit details
    Browse the repository at this point in the history

  37. add data domain unit tests

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1ac9384 View commit details
    Browse the repository at this point in the history

  38. add pydantic to root requirements.txt

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0d0c2e2 View commit details
    Browse the repository at this point in the history

  39. DataDomain, handle case when custom_data_fields=None

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2a79767 View commit details
    Browse the repository at this point in the history

  40. remove erroneous TODO comments

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    91bc468 View commit details
    Browse the repository at this point in the history

  41. @robertbartel confirmed in NOAA-OWP#239 that category and data_domain… 

    … are not optional fields
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    71f131e View commit details
    Browse the repository at this point in the history

  42. remove commented out Dataset factory_init_from_deserialized_json

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8a42ba7 View commit details
    Browse the repository at this point in the history

  43. fix DataDomain's dict method. related to NOAA-OWP#245

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1403cae View commit details
    Browse the repository at this point in the history

  44. revert DataRequirement's __eq__ implimentation

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e190e7f View commit details
    Browse the repository at this point in the history

  45. add note to remove DataDomain.custom_data_fields in future. relates n… 

    …ote to NOAA-OWP#245
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    88c0b4d View commit details
    Browse the repository at this point in the history

  46. exclude custom_data_fields during serialization if empty T variant. 

    This breaks with Serializable's convention to only exclude `None` value
fields.
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9f402cd View commit details
    Browse the repository at this point in the history

  47. add field_serializers Config option to Serializable 

    The field_serializers Config option is a apping of field name to
callable that changes the default serialized form of a field (i.e.
to_dict, to_json, dict, json). This is often helpful when a field
requires a use case specific representation (i.e. datetime) or is not
JSON serializable. For example, if a field is a datetime type, this
feature enables changing how that datetime object is serialized (e.g.
ISO8601 with only seconds).

The main intent of this feature is to discourage subclasses from
overriding `dict` to implement use case specific serialization and
provide a pathway to achieve this.
    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    06d0ca0 View commit details
    Browse the repository at this point in the history

  48. fix type hints

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    27ca6bf View commit details
    Browse the repository at this point in the history

  49. test Serializable field_serializer Config option

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4b03da5 View commit details
    Browse the repository at this point in the history

  50. simplify Dataset's dict override with config field_serializer

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    54554fe View commit details
    Browse the repository at this point in the history

  51. refactor ContinuousRestriction to use config field_serializers

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    6e35f10 View commit details
    Browse the repository at this point in the history

  52. DataDomain now factory inits continuous_restrictions

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7ead4ae View commit details
    Browse the repository at this point in the history

  53. remove commented code

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    05a62c8 View commit details
    Browse the repository at this point in the history

  54. fix test that was failing for the right reason

    @aaraney
    aaraney committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    3eff4fa View commit details
    Browse the repository at this point in the history