-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dmod.core serialization and deserialization types #256
Merged
aaraney
merged 54 commits into
NOAA-OWP:pydantic-serializable
from
aaraney:refactor-core-rebase
Jan 25, 2023
Merged
Refactor dmod.core serialization and deserialization types #256
aaraney
merged 54 commits into
NOAA-OWP:pydantic-serializable
from
aaraney:refactor-core-rebase
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subtypes of this enum variant that are embedded in a pydantic model will be: - coerced into an enum instance using member name (case insensitive) - and expose member names (upper case) in model json schema.
… all other as 'Any'
… are not optional fields
This breaks with Serializable's convention to only exclude `None` value fields.
The field_serializers Config option is a apping of field name to callable that changes the default serialized form of a field (i.e. to_dict, to_json, dict, json). This is often helpful when a field requires a use case specific representation (i.e. datetime) or is not JSON serializable. For example, if a field is a datetime type, this feature enables changing how that datetime object is serialized (e.g. ISO8601 with only seconds). The main intent of this feature is to discourage subclasses from overriding `dict` to implement use case specific serialization and provide a pathway to achieve this.
This was referenced Jan 25, 2023
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #239 for comments and discussion. This PR required resubmission due to a merge conflict.