Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perturbation/Increments for cold starts #340

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

pjpegion
Copy link

@pjpegion pjpegion commented May 8, 2024

Description

Currently the model can only read in an increment file if initializing with a restart file. This functionality is also used to read in ensemble perturbations, and should also work for a external initial condition. The solution is to move the call to read_da_inc outside the if external_ic/restart logic.

Fixes # (issue)

FV3 is not able to apply DA increment when cold staring #339

How Has This Been Tested?

So far, I have run limited regression tests on gaea, and tested that the perturbations are being read in during a cold start. The regression tests pass.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • [ X I have performed a self-review of my own code
  • [ X I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@laurenchilutti
Copy link
Contributor

Do you have a suggestion on from EMC or the UFS community can review this?

@lharris4
Copy link
Contributor

lharris4 commented May 9, 2024

@pjpegion @laurenchilutti This looks OK to me. There is no reason we can't use this method to apply to arbitrary initialization methods (restart, external_ic, or ideal).

@jkbk2004
Copy link

jkbk2004 commented Jun 7, 2024

All tests are done ok at ufs-community/ufs-weather-model#2269. @bensonr @laurenchilutti can you merge this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants