Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perturbation/Increments for cold starts #832

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

pjpegion
Copy link
Collaborator

@pjpegion pjpegion commented May 8, 2024

Description

Currently the model can only read in an increment file if initializing with a restart file. This functionality is also used to read in ensemble perturbations, and should also work for a external initial condition. The solution is to move the call to read_da_inc outside the if external_ic/restart logic.

There should be no changes to any regression tests.

Issue(s) addressed

Testing

How were these changes tested?
I used a regression test sandbox to compare a non-pertrubed run (which passes the RT) with a new perturbed run, and the differences are what I expect.
What compilers / HPCs was it tested with?
gaea - intel
Are the changes covered by regression tests? No, for some reason there is no checking of the read_da_increment capability anymore.
Have the ufs-weather-model regression test been run? On what platform?
Not the full suite

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
    -No
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@DusanJovic-NOAA DusanJovic-NOAA changed the title update gitmodules Perturbation/Increments for cold starts May 17, 2024
@zach1221
Copy link
Collaborator

zach1221 commented Jun 7, 2024

@jkbk2004 cubed-sphere PR merged.
NOAA-GFDL/GFDL_atmos_cubed_sphere@ab195d5

@zach1221 zach1221 requested a review from jkbk2004 June 7, 2024 20:07
@jkbk2004 jkbk2004 merged commit 07c26d1 into NOAA-EMC:develop Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants