Upp local memory #284
Upp local memory #284
Conversation
WenMeng-NOAA
requested review from
HuiyaChuang-NOAA and
GeorgeVandenberghe-NOAA
|
Have regression tests been run on all supported platforms? |
|
I run rt_for_developer.sh to do regression test, this script is for Dell only. I have an account on surge/luna. Which script is ready for surge/luna test? Thanks! |
|
@GeorgeVandenberghe-NOAA |
|
@BoCui-NOAA See the UPP regression test procedure at https://docs.google.com/document/d/1gtk1DBxEa9GsaWbxrxtB4Ot7U_lNIHjLXaU2F6FyD7M/edit |
|
The UPP standalone tests on Dell and Cray are done. I have no account on Hera. Can anybody kindly offer the regression test on Hera? Thanks! |
I will coordinate between Wen and Yali on this. |
|
I can conduct the tests on Hera. |
|
@BoCui-NOAA Since your changes passed the UPP regression tests on WCOSS, could you removed these commented original lines in your branch? |
|
@WenMeng-NOAA I already deleted the commented lines and updated my branch. |
|
Could you explain in more detail why we need full domain CEIL on each MPI
rank? I am concerned I could miss some of these too in my 2D
decomposition analysis.
…On Fri, Apr 2, 2021 at 10:38 AM BoCui-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sorc/ncep_post.fd/CLDRAD.f
<#284 (comment)>:
> @@ -159,7 +160,9 @@ SUBROUTINE CLDRAD
real :: ceiling_thresh_cldfra, cldfra_max, &
zceil, zceil1, zceil2, previous_sum, &
ceil_min, ceil_neighbor
- real,dimension(im,jm) :: ceil
+
+ real,dimension(im,jsta:jend) :: ceil
I will take a look and reverse the change. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#284 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FTVPJOGFR3PMRQROF3TGXJFFANCNFSM42EYXVCA>
.
--
George W Vandenberghe
*IMSG* at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
@GeorgeVandenberghe-NOAA We have a residue issue that the pe test for hrrr/rap are not bitwise identical in field scloud base height and pressure. These two fields are computed with GSL specified algorithms. GSL promise for improving them. I would like to keep the current setting until GSL delivery the changes. |
|
Any idea on when they will deliver the change. Not knowing where this is
happening means I could induce a problem with 2D changes also
…On Fri, Apr 2, 2021 at 11:04 AM WenMeng-NOAA ***@***.***> wrote:
@GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> We
have a residue issue that the pe test for hrrr/rap are not bitwise
identical in field scloud base height and pressure. These two fields are
computed with GSL specified algorithms. GSL promise for improving them. I
would like to keep the current setting until GSL delivery the changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#284 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDS4FSMVR4A2AHGQKIVKLLTGXMILANCNFSM42EYXVCA>
.
--
George W Vandenberghe
*IMSG* at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2141
College Park, MD 20740
***@***.***
301-683-3769(work) 3017751547(cell)
|
|
@GeorgeVandenberghe-NOAA I will coordinate with GSL if they get new changes. I feel this could be a halo exchange issue in GSL |
|
@BoCui-NOAA Could you sync your feature branch with upstream/develop? This PR would be the next one for merging. |
Fix an out-of-bounds read in CLDRAD accessing level lm+1 (NOAA-EMC#286)
|
@WenMeng-NOAA I notice there are changes for CLDRAD.f Are they for fixing the halo exchange issue you mentioned? For the array ceil, is it ok now to has dimension(im,jsta:jend)? |
|
@BoCui-NOAA The bug fix from GSL is for another issue. I would like keep ceil unchanged until that pe test issue is solved. |
|
I already synced my feature branch with EMC_post/develop, the ceil array in CLDRAD.f was changed back to original dimension(im,jm). |
|
The UPP standalone tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found. This PR is ready for merging. |
…C#284) * Remove all references to /lfs3 on Jet * Add Ben and Ratko to the CODEOWNERS file * Replace hard-coded make_orog module file with build-level module file in UFS_UTILS * Remove hard-coded make_sfc_climo module file * Add changes for merged chgres_cube code * Add changes for merged chgres_cube code * Minor tweak to FCST_LEN_HRS default in config.community.sh * Changes to make the release version of chgres_cube run in regional_workflow * Changes for regional_grid build on Jet * Changes to regional_grid build for Hera * Change regional_grid makefile for hera * Remove leading zero from FCST_LEN_HRS in config.community.sh * Remove /sorc directory * Remove build module files for codes originally in the regional_workflow repository. Remove run-time make_grid module file for all platforms. Will be sourced from UFS_UTILS from now on. * Update regional grid template for newest code * Copy make_grid module file from UFS_UTILS * Add make_grid.local file for most platforms * Remove alpha and kappa parameters from the regional_grid namelist * Modifications to file type conventions in the chgres_cube namelist for FV3GFS and GSMGFS nemsio files * Set convert_nst=False for global grib2 FV3GFS files when running chgres_cube * Add tracers back into nemsio file processing * Changes to the make_lbcs ex-script (remove all surface-related variables) * Fix for modulefiles * Fixes after merging authoritative repo into fork * Add Thompson climo to chgres_cube namelist for appropriate external model/SDF combinations * Commit new locations for Thompson climo fix file * Change FIXsar to FIXLAM * Change gfs_bndy.nc to gfs.bndy.nc * Move file * Bug fixes to setup.sh and exregional_make_ics.sh * Add support for NAM grib2 files * Path fix * Typo fix * Fix extension on UPP grib2 files * Bug fix for if statement * Add .grib2 extension to soft links * Fix nsoill_out values based on LSM scheme in CCPP suite * Fix grib2 extensions * Add if statement for varmap tables when using Thompson MP and initializing from non-RAP/HRRR data * Final modifications to support NAM grib2 files in regional_workflow * Set climo as default for soil variables when using HRRRX (user will need change this if they know these variables are available for the dates they are running). * Add FV3_CPT_v0 to varmap if statement * Changes to post file names to make model lowercase and move ${fhr} to three values instead of two * Change "rrfs" to "${NET}" instead * Revert "Add FV3_CPT_v0 to varmap if statement" This reverts commit b04ad0b3c8c554f664c6790030a4f33b5a395023. * Add if statement to set all ad-hoc scheme magnitudes to -999.0 if not being used.
…OAA-EMC#284)" (NOAA-EMC#288) This reverts commit 465416f.
Update all UPP local arrays to dimension jsta_2l:jend_2u when possible