Fix an out-of-bounds read in CLDRAD that crashes RRFS post #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelTrahanNOAA
changed the title
|
@SamuelTrahanNOAA Thanks for submitting this bug fix. Could you open a new issue at https://github.com/NOAA-EMC/EMC_post/issues for this pull request? A short description would be good enough. |
|
@WenMeng-NOAA The PR is #287 |
jaymes-kenyon
approved these changes
Apr 2, 2021
|
I have confirmed this resolves #287 with over 200 tests on Jet. @jaymes-kenyon has done independent tests, and confirmed the same. |
|
The UPP standard-alone tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found. This PR is ready for merging. |
WenMeng-NOAA
approved these changes
Apr 2, 2021
BoCui-NOAA
added a commit
to BoCui-NOAA/EMC_post
that referenced
this pull request
Apr 2, 2021
Fix an out-of-bounds read in CLDRAD accessing level lm+1 (NOAA-EMC#286)
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A loop in CLDRAD was reading out-of-bounds (level
lm+1). This was detected when the RRFS post randomly crashed on that line about 25% of the time. The bug fix in this PR reliably prevents that crash. The developer of that code, @jaymes-kenyon, confirmed that the bug fix will not affect the algorithm (other than preventing it from crashing).Resolves #287