replace user and role creation with corresponding modules #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new variables to docs
tbauriedel
requested changes
May 27, 2024
tbauriedel
requested changes
May 27, 2024
|
Since we want to use these modules and the need the python3 module "elasticsearch", we should consider to install the module as part of the role. The templates for the role and user can be deleted I guess. They are not used anymore. |
tbauriedel
approved these changes
May 31, 2024
tbauriedel
approved these changes
May 31, 2024
tbauriedel
previously approved these changes
May 31, 2024
|
Another review is needed because I have added some changes... |
widhalmt
requested changes
Jun 5, 2024
There was a problem hiding this comment.
I found a view things that might need to be changed.
Please make sure installing the packagaes really works on all operating systems. And maybe move the installation to the elasticstack role so we don't have to run the same code every time we need to handle users.
Co-authored-by: Thomas Widhalm <widhalmt@widhalm.or.at>
Co-authored-by: Thomas Widhalm <widhalmt@widhalm.or.at>
|
Pipelines failing to bug #326 |
|
(Ansible verbosity 3 needs to be removed before merging) |
widhalmt
approved these changes
Jun 7, 2024
1 task
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
I replaced the old functionality of creating users and roles of logstash with the corresponding modules. Also i added a few new variables to default/main.yml which are used to make the user and role creation more variable. The documenation was also adjusted accordingly. Cause the modules don't support the use of password hashes atm all variables corresponding to password hashes in logstash have been removed. --------- Co-authored-by: Tobias Bauriedel <tobias.bauriedel@netways.de> Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de> Co-authored-by: Tobias Bauriedel <tobias@bauriedel.de> Co-authored-by: Thomas Widhalm <widhalmt@widhalm.or.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the old functionality of creating users and roles of logstash with the corresponding modules. Also i added a few new variables to default/main.yml which are used to make the user and role creation more variable. The documenation was also adjusted accordingly. Cause the modules don't support the use of password hashes atm all variables corresponding to password hashes in logstash have been removed.