Skip to content

Fix minor problems with lint etc. #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Fix minor problems with lint etc. #326

merged 6 commits into from
Jun 7, 2024

Conversation

widhalmt
Copy link
Member

@widhalmt widhalmt commented Jun 6, 2024

With updated versions of tools we use for testing our tests now fail. This PR sums up minor changes to remove lint and other minor flaws.

@widhalmt widhalmt added the bug Something isn't working label Jun 6, 2024
@widhalmt widhalmt added this to the 0.1.0 milestone Jun 6, 2024
@widhalmt widhalmt self-assigned this Jun 6, 2024
@widhalmt widhalmt marked this pull request as draft June 6, 2024 09:19
@widhalmt widhalmt marked this pull request as ready for review June 6, 2024 15:33
@widhalmt
Copy link
Member Author

widhalmt commented Jun 6, 2024

Please read the comments above. It seems like there's a bug in ES 8.14.0 that breaks our tests for Rocky Linux.

@tbauriedel
Copy link
Member

We should create an issue to reenable these checks again, once the bug is fixed.

@widhalmt widhalmt added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 827a4b5 Jun 7, 2024
4 checks passed
@widhalmt widhalmt deleted the fix/lint branch June 7, 2024 08:24
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
With updated versions of tools we use for testing our tests now fail.
This PR sums up minor changes to remove lint and other minor flaws.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants