Skip to content

fix fletcher32, add tests#133

Merged
bnlawrence merged 1 commit intoNCAS-CMS:mainfrom
kmuehlbauer:fix-fletcher32
Oct 22, 2025
Merged

fix fletcher32, add tests#133
bnlawrence merged 1 commit intoNCAS-CMS:mainfrom
kmuehlbauer:fix-fletcher32

Conversation

@kmuehlbauer
Copy link
Collaborator

Description

This fixes the current implementation of the fletcher32 algorithm. The current testsuite didn't catch it, I only found it by accident while running the xarray testsuite. It therefore also adds a comprehensive test matrix to run over different filter pipelines including chunking, compression, fletcher32 and shuffle.

Closes #128

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@kmuehlbauer kmuehlbauer mentioned this pull request Oct 22, 2025
7 tasks
@bnlawrence bnlawrence merged commit 29b2b59 into NCAS-CMS:main Oct 22, 2025
13 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-fletcher32 branch October 22, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fletcher32 filter broken

2 participants