Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 74.05% 74.03% -0.02%
==========================================
Files 11 11
Lines 2598 2596 -2
Branches 406 406
==========================================
- Hits 1924 1922 -2
Misses 565 565
Partials 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Great, this worked. It took a while to bubble up from xarray over h5netcdf to pyfive. And then, such nasty things going on while mixing native Python int and numpy in arithmetic. |
Collaborator
Author
|
Ready for review! |
Collaborator
Author
|
@bnlawrence It would be great, if you could have a look at these three lines of code. Thanks! |
Collaborator
Author
|
overridde by #133, branching issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the current implementation of the fletcher32 algorithm. The current testsuite didn't catch it, I only found it by accident while running the xarray testsuite. It therefore also adds a comprehensive test matrix to run over different filter pipelines including chunking, compression, fletcher32 and shuffle.
Closes #128
Before you get started
Checklist