Skip to content

fix fletcher32, add tests#129

Closed
kmuehlbauer wants to merge 1 commit intoNCAS-CMS:mainfrom
kmuehlbauer:main
Closed

fix fletcher32, add tests#129
kmuehlbauer wants to merge 1 commit intoNCAS-CMS:mainfrom
kmuehlbauer:main

Conversation

@kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Oct 17, 2025

Description

This fixes the current implementation of the fletcher32 algorithm. The current testsuite didn't catch it, I only found it by accident while running the xarray testsuite. It therefore also adds a comprehensive test matrix to run over different filter pipelines including chunking, compression, fletcher32 and shuffle.

Closes #128

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.03%. Comparing base (08637c3) to head (958e935).
⚠️ Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   74.05%   74.03%   -0.02%     
==========================================
  Files          11       11              
  Lines        2598     2596       -2     
  Branches      406      406              
==========================================
- Hits         1924     1922       -2     
  Misses        565      565              
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmuehlbauer
Copy link
Collaborator Author

Great, this worked. It took a while to bubble up from xarray over h5netcdf to pyfive. And then, such nasty things going on while mixing native Python int and numpy in arithmetic.

@kmuehlbauer
Copy link
Collaborator Author

Ready for review!

@kmuehlbauer
Copy link
Collaborator Author

@bnlawrence It would be great, if you could have a look at these three lines of code. Thanks!

@kmuehlbauer
Copy link
Collaborator Author

overridde by #133, branching issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fletcher32 filter broken

1 participant