Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List datasets more info #444

Merged
merged 2 commits into from
Sep 2, 2024
Merged

List datasets more info #444

merged 2 commits into from
Sep 2, 2024

Conversation

MalinAhlberg
Copy link
Member

@MalinAhlberg MalinAhlberg commented Aug 29, 2024

Related issue(s) and PR(s)
This PR closes #438 .

Description
sda-cli list -datasets will print number of files and dataset size:

DatasetID                                	 Files 	 Size
https://doi.example/ty009.sfrrss/600.45asasga 	 3 	 3.1 MB
https://doi.example/ty009.sfrrss/Dataset         1 	 1.1 MB

How to test
From the root folder run the setup script:

bash .github/integration/setup/setup.sh

(note to future self: if it does not work, remove all containers and run docker volume rm -f $(docker volume ls -f "dangling=true")).
Then run:

./sda-cli list -config testing/s3cmd-download.conf -datasets -url http://localhost:8080 

And get

DatasetID                                	 Files 	 Size
https://doi.example/ty009.sfrrss/600.45asasga 	 3 	 3.1 MB

Base automatically changed from feature/list-dataset-show-more-info to main September 2, 2024 07:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 38.79%. Comparing base (d24ea15) to head (d9de7b2).

Files with missing lines Patch % Lines
list/list.go 0.00% 19 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   39.04%   38.79%   -0.25%     
==========================================
  Files          11       11              
  Lines        1903     1915      +12     
==========================================
  Hits          743      743              
- Misses       1048     1060      +12     
  Partials      112      112              
Flag Coverage Δ
unittests 38.79% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MalinAhlberg MalinAhlberg marked this pull request as ready for review September 2, 2024 07:55
@MalinAhlberg MalinAhlberg requested a review from a team September 2, 2024 07:55
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also like the "note to self" on the description 😄

@jbygdell jbygdell added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 53912fb Sep 2, 2024
6 checks passed
@jbygdell jbygdell deleted the feature/list-datasets-more-info branch September 2, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[list] Show more metadata information when showing information about datasets
4 participants