Skip to content

Conversation

@BrianSipos
Copy link
Collaborator

Closes #167

@BrianSipos BrianSipos self-assigned this Apr 3, 2025
@BrianSipos BrianSipos added this to the ANMS v2.0.0 milestone Apr 3, 2025
@BrianSipos BrianSipos added this to ANMS Apr 3, 2025
@github-project-automation github-project-automation bot moved this to Todo in ANMS Apr 3, 2025
@BrianSipos BrianSipos moved this from Todo to In Progress in ANMS Apr 3, 2025
@BrianSipos BrianSipos marked this pull request as ready for review April 14, 2025 20:12
@DavidEdell
Copy link
Contributor

Is the intention that ion-manager is now optional in favor of amp-manager? Or is it now required for most deployments to start the agent-compose.yml file alongside it?

As it stands now, I believe nginx (I'm working on removing this dependency) will fail if only docker-compose.yml is started with this changeset since ion-manager would be unavailable.

  1. For the services status page (system_status.py), should amp-manager replace ion-manager, or be added in addition to it?
  2. Same question for proxy settings in nginx (or it's replacement).

…ore clear. Moved socket bind mount to an environment controlled path.
@BrianSipos
Copy link
Collaborator Author

Is the intention that ion-manager is now optional in favor of amp-manager? Or is it now required for most deployments to start the agent-compose.yml file alongside it?

As it stands now, I believe nginx (I'm working on removing this dependency) will fail if only docker-compose.yml is started with this changeset since ion-manager would be unavailable.

  1. For the services status page (system_status.py), should amp-manager replace ion-manager, or be added in addition to it?
  2. Same question for proxy settings in nginx (or it's replacement).

The actual AMP manager is now running under hostname amp-manager so anything that before addressed it via ion-manager needs to use the DNS name amp-manager instead. The manager configuration purpose, etc. has not changed though so should be usable in the same way just via different hostname.

@BrianSipos BrianSipos mentioned this pull request Apr 22, 2025
@BrianSipos BrianSipos marked this pull request as draft April 22, 2025 14:53
@BrianSipos
Copy link
Collaborator Author

This PR should also separate the "anms" operational network from a "testenv" network between ION nodes (using static addressing) to make it fully clear that they are independent from each other.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9 Security Hotspots

See analysis details on SonarQube Cloud

@BrianSipos BrianSipos closed this Jun 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in ANMS Jun 3, 2025
@BrianSipos BrianSipos deleted the 167-ion-split-proxy branch December 1, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove ION dependency

3 participants