A few improvements to StakeAggregator #7705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
andll
reviewed
Jan 26, 2023
| } | ||
| InsertResult::QuorumReachedWithCert(cert) => Ok(cert), | ||
| InsertResult::QuorumReached => { | ||
| unreachable!("insert should only return QuorumReachedWithCert"); |
There was a problem hiding this comment.
I think you can avoid unreachable here by adding generic parameter to InsertResult.
insert_generic would return InsertResult<()> and insert would return InsertResult<Cert>. This way only one enum element is needed(QuorumReached)
There was a problem hiding this comment.
Updated. It does work though the translation from InsertResult<()> to InsertResult is a bit ugly.
andll
approved these changes
Jan 27, 2023
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
This PR adds a specialization for AuthSignInfo. This will allow the stake aggregator reused much better in many other places. Specifically: 1. Added epoch check to make sure AuthSignInfo is from the same epoch as committee 2. Check that authority is valid (by checking that stake is > 0) 3. By actively aggregating the signatures into a quorum signature and return it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a specialization for AuthSignInfo. This will allow the stake aggregator reused much better in many other places. Specifically: