Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag for enabling msm API in Move (on only in devnet) #16838

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

benr-ml
Copy link
Contributor

@benr-ml benr-ml commented Mar 24, 2024

Description

Add a flag for enabling msm API in Move (on only in devnet).

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:40am
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:40am
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:40am
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:40am
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:40am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:40am

@vercel vercel bot temporarily deployed to Preview – mysten-ui March 24, 2024 13:17 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui March 24, 2024 13:41 Inactive
@benr-ml benr-ml changed the title Add a flag for enabling msm API in Move (enabled only in devnet) Add a flag for enabling msm API in Move (on only in devnet), and enable EC ops Mar 24, 2024
@benr-ml benr-ml changed the title Add a flag for enabling msm API in Move (on only in devnet), and enable EC ops Add a flag for enabling msm API in Move (on only in devnet) Mar 24, 2024
@benr-ml benr-ml marked this pull request as ready for review March 24, 2024 14:03
@benr-ml benr-ml requested a review from mystenmark as a code owner March 24, 2024 14:03
@benr-ml benr-ml requested review from lxfind, ebmifa and kchalkias March 24, 2024 14:20
@benr-ml benr-ml requested a review from kchalkias March 24, 2024 17:00
@vercel vercel bot temporarily deployed to Preview – mysten-ui March 25, 2024 06:56 Inactive
@benr-ml benr-ml merged commit 87e0004 into main Mar 25, 2024
41 checks passed
@benr-ml benr-ml deleted the ben/dis_msm branch March 25, 2024 18:01
benr-ml added a commit that referenced this pull request Mar 25, 2024
…le EC ops (#16839)

## Description 

Add a flag for enabling msm API in Move (on only in devnet), and also
enable EC ops in all networks.
Cherrypick of #16838 (on top of #16795)

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [x] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [x] breaking change for FNs (FN binary must upgrade)
- [x] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Enable EC operations in Move.
emmazzz pushed a commit that referenced this pull request Mar 27, 2024
## Description 

Add a flag for enabling msm API in Move (on only in devnet).


## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
leecchh pushed a commit that referenced this pull request Mar 27, 2024
## Description 

Add a flag for enabling msm API in Move (on only in devnet).


## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants