-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable EC ops on all networks #16795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benr-ml
requested review from
lxfind,
ebmifa and
kchalkias
and removed request for
mystenmark
March 22, 2024 08:34
lxfind
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
benr-ml
added a commit
that referenced
this pull request
Mar 22, 2024
Enable [EC ops](https://github.com/MystenLabs/sui/blob/3cdb1f38616b5d456e468c72892bd53e39dc42fe/crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move#L27-L28) on all networks (currently enabled only on devnet). The plan is to cherrypick this to release 1.21, but only changing its protocol config to version 41. Increasing here the version of main to be larger than the new one in the release. How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration
This was referenced Mar 22, 2024
benr-ml
added a commit
that referenced
this pull request
Mar 25, 2024
…le EC ops (#16839) ## Description Add a flag for enabling msm API in Move (on only in devnet), and also enable EC ops in all networks. Cherrypick of #16838 (on top of #16795) ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [x] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [x] breaking change for FNs (FN binary must upgrade) - [x] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Enable EC operations in Move.
emmazzz
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Description Enable [EC ops](https://github.com/MystenLabs/sui/blob/3cdb1f38616b5d456e468c72892bd53e39dc42fe/crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move#L27-L28) on all networks (currently enabled only on devnet). The plan is to cherrypick this to release 1.21, but only changing its protocol config to version 41. Increasing here the version of main to be larger than the new one in the release. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
tonylee08
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Description Enable [EC ops](https://github.com/MystenLabs/sui/blob/3cdb1f38616b5d456e468c72892bd53e39dc42fe/crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move#L27-L28) on all networks (currently enabled only on devnet). The plan is to cherrypick this to release 1.21, but only changing its protocol config to version 41. Increasing here the version of main to be larger than the new one in the release. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable EC ops on all networks (currently enabled only on devnet).
The plan is to cherrypick this to release 1.21, but only changing its protocol config to version 41.
Increasing here the version of main to be larger than the new one in the release.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes