Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EC ops on all networks #16795

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Enable EC ops on all networks #16795

merged 2 commits into from
Mar 22, 2024

Conversation

benr-ml
Copy link
Contributor

@benr-ml benr-ml commented Mar 21, 2024

Description

Enable EC ops on all networks (currently enabled only on devnet).

The plan is to cherrypick this to release 1.21, but only changing its protocol config to version 41.
Increasing here the version of main to be larger than the new one in the release.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 8:10am
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 8:10am
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 8:10am
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 8:10am
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 8:10am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 8:10am

Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@benr-ml benr-ml merged commit 9dbff7f into main Mar 22, 2024
67 checks passed
@benr-ml benr-ml deleted the ben/enable_ec branch March 22, 2024 20:15
benr-ml added a commit that referenced this pull request Mar 22, 2024
Enable [EC
ops](https://github.com/MystenLabs/sui/blob/3cdb1f38616b5d456e468c72892bd53e39dc42fe/crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move#L27-L28)
on all networks (currently enabled only on devnet).

The plan is to cherrypick this to release 1.21, but only changing its
protocol config to version 41.
Increasing here the version of main to be larger than the new one in the
release.

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
benr-ml added a commit that referenced this pull request Mar 25, 2024
…le EC ops (#16839)

## Description 

Add a flag for enabling msm API in Move (on only in devnet), and also
enable EC ops in all networks.
Cherrypick of #16838 (on top of #16795)

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [x] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [x] breaking change for FNs (FN binary must upgrade)
- [x] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Enable EC operations in Move.
emmazzz pushed a commit that referenced this pull request Mar 27, 2024
## Description 

Enable [EC
ops](https://github.com/MystenLabs/sui/blob/3cdb1f38616b5d456e468c72892bd53e39dc42fe/crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move#L27-L28)
on all networks (currently enabled only on devnet).

The plan is to cherrypick this to release 1.21, but only changing its
protocol config to version 41.
Increasing here the version of main to be larger than the new one in the
release.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
tonylee08 pushed a commit that referenced this pull request Mar 27, 2024
## Description 

Enable [EC
ops](https://github.com/MystenLabs/sui/blob/3cdb1f38616b5d456e468c72892bd53e39dc42fe/crates/sui-framework/packages/sui-framework/sources/crypto/bls12381.move#L27-L28)
on all networks (currently enabled only on devnet).

The plan is to cherrypick this to release 1.21, but only changing its
protocol config to version 41.
Increasing here the version of main to be larger than the new one in the
release.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants