Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Make sure to use the Composer-installed development tools #862

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

oliverklee
Copy link
Contributor

We now provide the path for the development tools within vendor/bin/.
This avoids system-installed versions of the same tools (e.g., PHPUnit)
from getting called instead (which might be a different version and
also might not use our Composer autoloader).

We now provide the path for the development tools within `vendor/bin/`.
This avoids system-installed versions of the same tools (e.g., PHPUnit)
from getting called instead (which might be a different version and
also might not use our Composer autoloader).
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May even mitigate somehow against an obscure attack vector too :)

@JakeQZ JakeQZ merged commit cf77b26 into master Apr 9, 2020
@JakeQZ JakeQZ deleted the bugfix/composer-dev-tools branch April 9, 2020 21:03
@oliverklee oliverklee removed the request for review from zoliszabo April 21, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants