Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Upgrade to V2 of the PHP setup GitHub action #861

Merged
merged 1 commit into from
Apr 9, 2020
Merged

[TASK] Upgrade to V2 of the PHP setup GitHub action #861

merged 1 commit into from
Apr 9, 2020

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 4.0.0 milestone Apr 9, 2020
@oliverklee oliverklee self-assigned this Apr 9, 2020
@oliverklee oliverklee marked this pull request as draft April 9, 2020 18:32
@oliverklee
Copy link
Contributor Author

We might need to fix #862 first. Let's see.

JakeQZ
JakeQZ approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to fix #862 first. Let's see.

Apparently so. I've merged #862 now, so if you rebase this, the build will hopefully be green, and then it can be merged (I'm approving the changes here too).

@oliverklee
Copy link
Contributor Author

Rebased and repushed.

@oliverklee oliverklee marked this pull request as ready for review April 9, 2020 21:27
@oliverklee
Copy link
Contributor Author

Yay, everything is green now! Merging.

@oliverklee oliverklee merged commit 2ec39dd into master Apr 9, 2020
@oliverklee oliverklee deleted the task/php-upgrade branch April 9, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ