Skip to content

[CLEANUP] Avoid Hungarian notation in AtRuleBlockList #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025
Merged

[CLEANUP] Avoid Hungarian notation in AtRuleBlockList #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/CSSList/AtRuleBlockList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,31 +15,31 @@ class AtRuleBlockList extends CSSBlockList implements AtRule
/**
* @var string
*/
private $sType;
private $type;

/**
* @var string
*/
private $sArgs;

/**
* @param string $sType
* @param string $sArgs
* @param int $iLineNo
* @param string $type
* @param string $arguments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like full words in my variables.

* @param int $lineNumber
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

*/
public function __construct($sType, $sArgs = '', $iLineNo = 0)
public function __construct($type, $arguments = '', $lineNumber = 0)
{
parent::__construct($iLineNo);
$this->sType = $sType;
$this->sArgs = $sArgs;
parent::__construct($lineNumber);
$this->type = $type;
$this->sArgs = $arguments;
}

/**
* @return string
*/
public function atRuleName()
{
return $this->sType;
return $this->type;
}

/**
Expand All @@ -63,7 +63,7 @@ public function render(OutputFormat $oOutputFormat): string
if ($sArgs) {
$sArgs = ' ' . $sArgs;
}
$sResult .= "@{$this->sType}$sArgs{$oOutputFormat->spaceBeforeOpeningBrace()}{";
$sResult .= "@{$this->type}$sArgs{$oOutputFormat->spaceBeforeOpeningBrace()}{";
$sResult .= $this->renderListContents($oOutputFormat);
$sResult .= '}';
$sResult .= $oOutputFormat->sAfterAtRuleBlock;
Expand Down