Skip to content

[CLEANUP] Avoid Hungarian notation in AtRuleBlockList #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

oliverklee
Copy link
Collaborator

Part of #756.

@oliverklee oliverklee self-assigned this Jan 25, 2025
@oliverklee oliverklee mentioned this pull request Jan 25, 2025
47 tasks
@oliverklee oliverklee changed the title [TASK] Avoid Hungarian notation in AtRuleBlockList [CLEANUP] Avoid Hungarian notation in AtRuleBlockList Jan 25, 2025
@coveralls
Copy link

coveralls commented Jan 25, 2025

Coverage Status

coverage: 42.138%. remained the same
when pulling 02e997b on task/hungarian-5
into 129f7ce on main.

* @param string $sArgs
* @param int $iLineNo
* @param string $type
* @param string $arguments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like full words in my variables.

* @param int $iLineNo
* @param string $type
* @param string $arguments
* @param int $lineNumber
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@JakeQZ JakeQZ merged commit 7c6845f into main Jan 26, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/hungarian-5 branch January 26, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants