Fix Slim SEO compatibility issue in Current_Site_Element #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add defensive null checks in output() method to prevent fatal errors when Slim SEO processes shortcodes before WP Ultimo is fully initialized. - Add null check for $this->site->get_active_site_url() call - Add null check for edit_site URL generation using $this->site->get_hash() - Add null check condition for admin link using $this->site->get_id() Resolves errors when Current_Site_Element shortcodes are processed during early WordPress initialization phases.
Added Composer patch to suppress ArrayAccess deprecation notices: - offsetSet() - Add #[\ReturnTypeWillChange] attribute - offsetGet() - Add #[\ReturnTypeWillChange] attribute - offsetExists() - Add #[\ReturnTypeWillChange] attribute This maintains backward compatibility while eliminating PHP 8+ warnings.
- Added ensure_setup() method to Base_Element class - Call ensure_setup() in all UI element output() methods - Remove _doing_it_wrong() errors, return empty string silently instead - Ensures compatibility when elements are processed during SEO operations This prevents setup() errors while maintaining defensive behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defensive null checks in output() method to prevent fatal errors when Slim SEO processes shortcodes before WP Ultimo is fully initialized.
Resolves errors when Current_Site_Element shortcodes are processed during early WordPress initialization phases.
Ref this PR : #179 and #159