Fix: Add defensive checks for Slim SEO plugin compatibility

[vuckro]

• Add null checks in UI element output methods
• Prevent errors when site/membership objects are null
• Ensures compatibility with Slim SEO plugin that calls output() directly
• Defensive programming approach for robustness

[superdav42]

What is it about Slim SEO that makes that properties null? Ideally any compatibility code would only be loaded if the Slim SEO plugin was loaded. In this case it does seem to make sense to just have defensive programming. However would it be possible to create get_site() and get_membership() methods to lazy load then objects if they are not already set? Such a pattern should allow output to always behave the same way.

[vuckro]

When Multisite Ultimate shortcodes are used on non-Multisite Ultimate pages, this error appear in Query Monitor when Slim SEO is enabled:

Uncaught Error: Call to a member function get_active_site_url() on null
in inc/ui/class-current-site-element.php:360

Maybe not the cleanest fix, but it works on my setup.
Let me know if you see any improvements.

[vuckro]

I'm trying to update with the recommendations quickly.

[vuckro]

I just updated the code following your recommendations.

Let me know if everything is correct or if you see any other improvements.

[superdav42]

Now that I see the problem I think you just need to call this function [wu_element_setup_preview](https://github.com/superdav42/wp-multisite-waas/blob/main/inc/functions/element.php#L18)() in the appropriate action. It seems to be an issue when bricks and slim seo is active. Probably you just need to to setup the preview in an action fired by the bricks plugin when it loads the editor.

See https://github.com/superdav42/wp-multisite-waas/blob/main/inc/compat/class-elementor-compat.php for how a class is setup to fix a similar problem in elementor. Particularly this line:

		add_action('elementor/widget/shortcode/skins_init', [$this, 'maybe_setup_preview']);

If the preview is setup correctly none of the other code changes in the other files will be necessary and they will show appropriate preview data. You should make a single class like Bricks_Compat which will keep all the code in once place.

[vuckro]

Thanks for the feedback and explanations.

I don't think Bricks is the problem (same error with only Slim SEO active + Multisite Ultimate).

Also, the approach with a compatibility class causes problems in my tests.
I'm going to revert to the original defensive changes, which were safer.

Hoping to hear back on this slim seo issue.

[superdav42]

Ok, this is simple enough to mitigate the bug that's in seo slim. I'm adding these _doing_it_wrong so it's obvious to a developer that something isn't working right, otherwise it may take some extensive troubleshooting to figure why the output is blank

[vuckro]

@superdav42 It seems that the merge did not completely resolve the issue with my first code proposal:

Can you take a look? I can create a temporary site if necessary.

Also following this issue #232, but no response for now