Skip to content

GH-3666 Fix multi-monitor dpi scaling on windows #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021
Merged

GH-3666 Fix multi-monitor dpi scaling on windows #3684

merged 1 commit into from
Mar 26, 2021

Conversation

natrow
Copy link
Contributor

@natrow natrow commented Mar 24, 2021

Disable qt 5.6 DPI scaling and use windows' builtin DPI scaling, which fixes scaling issues on windows multi-monitor setups with different resolutions.

Tested on Windows 10 version 2004 build 19041.867 using build instructions described here.

Fixes GH-3666

@peterix
Copy link
Member

peterix commented Mar 26, 2021

Looks like a fun hack. Let's merge it and see what happens.

@peterix
Copy link
Member

peterix commented Mar 26, 2021

However, please fix the commit message so it either has the NOISSUE prefix ot a GH-#### prefix that references a github issue.

@natrow natrow changed the title Fix multi-monitor dpi scaling on windows GH-3666 Fix multi-monitor dpi scaling on windows Mar 26, 2021
@natrow
Copy link
Contributor Author

natrow commented Mar 26, 2021

I changed the first comment and title to have the github issue, however I'm having trouble changing the actual commit itself...

@phit
Copy link
Contributor

phit commented Mar 26, 2021

if you still have it locally
git commit --amend
change title, save
git push -f

Disable qt 5.6 DPI scaling and use windows' builtin DPI scaling, which works much better on multi-monitor setups
@peterix peterix merged commit adf2301 into MultiMC:develop Mar 26, 2021
@Janrupf Janrupf mentioned this pull request Mar 27, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect window border scaling when moving between monitors.
4 participants