Incorrect window border scaling when moving between monitors.

[natrow]

OS:
Windows 10, x64

Steps to reproduce:
-open multimc on one monitor
-move the window to a secondary monitor of a different resolution

Description of Issue:
Multimc's UI itself scales fine, however, the window border (mostly the title bar) becomes the wrong size. I use a 4k monitor as the primary one, so when I move it to my secondary 1080p monitor it's 4x larger than it should be.

[peterix]

MultiMC does nothing with title bars on any OS. They are the responsibility of whatever window manager you are using.

So, Windows bug?

[AverageComet250]

Yes and no. I've seen this too, most recently yesterday and it's something I've always seen. It's also never happened with another app, so it's either a multimc or Qt bug

[natrow]

This is a fairly common bug for windows programs especially Qt ones, so I'm not sue. I believe Okular by KDE fixed this somewhat recently in their program.

[phit]

this looks like the commit in question KDE/okular@3311bcb
could be worth a shot?

[natrow]

Judging by this stackoverflow post
https://stackoverflow.com/questions/35816944/improper-scaling-of-qt-desktop-application-in-windows-10

that might actually fix the problem

[natrow]

this also has a similar approach
https://vicrucann.github.io/tutorials/osg-qt-high-dpi/

Judging by this stackoverflow post
https://stackoverflow.com/questions/35816944/improper-scaling-of-qt-desktop-application-in-windows-10

that might actually fix the problem

[peterix]

This enum was introduced or modified in Qt 5.14.

We use 5.6

[peterix]

Also, most of this does not apply.

[natrow]

OK I fixed this issue on my PC (I'm not sure how to implement this in code since I'm not great with C++ or anything, it seems like mingw hasn't implemented any compatibility for the SetProcessDPIAware() function).

Steps to fix:
find multimc.exe
right click, select Properties
go to Compatibility tab
click Change high DPI settings
check Override high DPI scaling behaviour
select "System" or "System (enhanced)" on the dropdown box

This does make the application's text render in 1080p on the 4k monitor however, causing it to look slightly blurry.

[natrow]

Actually, I've fixed this problem properly and created a pull request.