Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactifying News #785

Merged
merged 4 commits into from
Sep 26, 2017
Merged

reactifying News #785

merged 4 commits into from
Sep 26, 2017

Conversation

gvn
Copy link
Contributor

@gvn gvn commented Sep 22, 2017

related to #776

@gvn gvn requested a review from mmmavis September 22, 2017 22:05
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good!

One thing I noticed is that all the glyphs used in news-item are all broken. But I guess it is probably not something related to this PR as I see the see issue on production.

@gvn
Copy link
Contributor Author

gvn commented Sep 26, 2017

Yeah, the glyphs are broken on prod right now, but will be fixed next time we do a prod push! 👍

@gvn gvn merged commit 432d47b into MozillaFoundation:master Sep 26, 2017
@gvn gvn deleted the gh-776 branch September 26, 2017 16:49
gvn added a commit that referenced this pull request Sep 26, 2017
* Reactify Homepage (#768)

* reactifying homepage

* only fetch homepage data for homepage

* fixups

* guarding against null data

* switching People over to XHRd React component (#778)

* reactifying Upcoming (#779)

* reactifying Upcoming

* better name

* removing unused test

* updated the serializer to yield a full glyph path (#784)

* updated the serializer to yield a full glyph path

* add the AWS location to the absolute glyph URL (#788)

* updated svg - error image (#789)

* Add related model name to hompepage admin header (#772)

* reactifying News (#785)

* reactifying News

* adding key props

* removing news json injection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants